-
Notifications
You must be signed in to change notification settings - Fork 715
Add runtime error tests #6698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add runtime error tests #6698
Conversation
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
… into chore/add-testing-to-runtime-errors
…g. Also removed MetadataAlreadySet Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
… comment Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
… into chore/add-testing-to-runtime-errors
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
…uint Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (28.50%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6698 +/- ##
============================================
- Coverage 79.47% 28.50% -50.97%
============================================
Files 577 578 +1
Lines 357469 358246 +777
============================================
- Hits 284089 102124 -181965
- Misses 73380 256122 +182742
... and 507 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
I am not yet convinced that my reasoning about my untested variants is correct. Still looking into it. Especially the AST errors. Having a hard time reasoning out when those would trigger.
Replaces #6690
Closes #6695