Skip to content

Conversation

@jacinta-stacks
Copy link
Contributor

@jacinta-stacks jacinta-stacks commented Nov 18, 2025

I am not yet convinced that my reasoning about my untested variants is correct. Still looking into it. Especially the AST errors. Having a hard time reasoning out when those would trigger.

Replaces #6690

Closes #6695

Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
…g. Also removed MetadataAlreadySet

Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
… comment

Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
…uint

Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 0% with 780 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.50%. Comparing base (62fe5cb) to head (ce93756).

Files with missing lines Patch % Lines
stackslib/src/chainstate/tests/runtime_tests.rs 0.00% 515 Missing ⚠️
clarity/src/vm/database/clarity_db.rs 0.00% 74 Missing ⚠️
pox-locking/src/pox_4.rs 0.00% 66 Missing ⚠️
clarity/src/vm/contexts.rs 0.00% 60 Missing ⚠️
clarity/src/vm/variables.rs 0.00% 44 Missing ⚠️
clarity/src/vm/database/sqlite.rs 0.00% 12 Missing ⚠️
stackslib/src/chainstate/tests/consensus.rs 0.00% 7 Missing ⚠️
stackslib/src/chainstate/tests/parse_tests.rs 0.00% 2 Missing ⚠️

❌ Your project check has failed because the head coverage (28.50%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (62fe5cb) and HEAD (ce93756). Click for more details.

HEAD has 49 uploads less than BASE
Flag BASE (62fe5cb) HEAD (ce93756)
117 68
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6698       +/-   ##
============================================
- Coverage    79.47%   28.50%   -50.97%     
============================================
  Files          577      578        +1     
  Lines       357469   358246      +777     
============================================
- Hits        284089   102124   -181965     
- Misses       73380   256122   +182742     
Files with missing lines Coverage Δ
clarity-types/src/types/mod.rs 47.95% <ø> (-47.86%) ⬇️
clarity/src/vm/costs/cost_functions.rs 59.64% <ø> (-40.36%) ⬇️
clarity/src/vm/functions/assets.rs 11.30% <ø> (-74.13%) ⬇️
stackslib/src/chainstate/tests/mod.rs 10.04% <ø> (-67.90%) ⬇️
stackslib/src/clarity_vm/database/marf.rs 43.11% <ø> (-15.96%) ⬇️
stackslib/src/chainstate/tests/parse_tests.rs 0.00% <0.00%> (-83.28%) ⬇️
stackslib/src/chainstate/tests/consensus.rs 0.00% <0.00%> (-96.30%) ⬇️
clarity/src/vm/database/sqlite.rs 58.02% <0.00%> (-23.84%) ⬇️
clarity/src/vm/variables.rs 46.15% <0.00%> (-47.18%) ⬇️
clarity/src/vm/contexts.rs 50.20% <0.00%> (-41.43%) ⬇️
... and 3 more

... and 507 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62fe5cb...ce93756. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants