Fix error string when converting string to ClarityVersion #6689
+4
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
… a VmExecutionError when parsing an input string Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
federico-stacks
approved these changes
Nov 17, 2025
Contributor
federico-stacks
left a comment
federico-stacks
left a comment
There was a problem hiding this comment.
Make sense! IMHO basic types shouldn't be aware of the clarity errors. They should be emitted based on the usage instead.
brice-stacks
approved these changes
Nov 17, 2025
Contributor
brice-stacks
left a comment
brice-stacks
left a comment
There was a problem hiding this comment.
This seems fine to me if no users of this complain about the error type (as evidenced by a lack of compile-time errors).
Merged
via the queue into
stacks-network:develop
with commit Nov 17, 2025
46d7bd1
308 of 312 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing clarity RuntimeError tests, I saw this. Fixed error message and also removed the use of VmExecutionError(RuntimeError). This error is not really meant to be used for input parsing/config parsing errors which is what it basically is in clarity-cli. Changed it to be just a string. Makes life easier for me and I think its actually more correct. Happy for push back on this though.