Added blockreplay profiler #6682
Open
+279
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-stacks
changed the title
rob-stacks
changed the title
Contributor
aaronb-stacks
left a comment
aaronb-stacks
left a comment
There was a problem hiding this comment.
This looks good to me, I just think we should further separate the cfg flag dependent code into a new struct so that the actual logic of the RPC endpoint is free of flags.
rob-stacks
changed the title
Contributor
adriano-stacks
left a comment
adriano-stacks
left a comment
There was a problem hiding this comment.
I am comment (instead of approving) just because of the Clippy warnings. Everything else is nits, feel free to address or ignore.
| txs_receipts.push(tx_result.receipt); | ||
| txs_receipts.push(( | ||
| tx_result.receipt, | ||
| profiler_result.cpu_instructions, |
Contributor
There was a problem hiding this comment.
Just a nit: do we consider the profiler results "receipts"?
Contributor
There was a problem hiding this comment.
Also is there a reason to pass the three members instead of profiler_result?
| events, | ||
| post_condition_aborted: receipt.post_condition_aborted, | ||
| vm_error: receipt.vm_error.clone(), | ||
| cpu_instructions: cpu_instructions.clone(), |
Contributor
There was a problem hiding this comment.
It looks like Clippy doesn't like these lines :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a profiler based on linux perf_events api (only x86-64 for now). This is the base for starting the optimization work on the clarity vm.
The patch exposes a new rust feature for the stackslib crate.
cargo build --features stackslib/profilerWill add to the blockreplay endpoint the ability to profile the cpu costs of every transaction in a block (currently the number of cpu instructions, cycles and ref cycles are reported)
To enable the feature you need to pass ?profiler=1 in the query string of the endpoint.
Note that the endpoint is protected by authentication.
Note 2: the linux perf_events api could be protected on your system. To allow non-privileged use you can run:
(this will allow unprivileged access to the perf_event api)
Note 3: currently the system works only on linux x86-64
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo