Skip to content

Conversation

@brice-stacks
Copy link
Contributor

Instead of setting the type of the output to the maximum size for any input, the type-checker now considers the actual type of the input when determining the type of the output.

Fixes #6582

Instead of setting the type of the output to the maximum size for any
input, the type-checker now considers the actual type of the input when
determining the type of the output.

Fixes stacks-network#6582
@brice-stacks brice-stacks requested review from a team as code owners October 20, 2025 16:42
@brice-stacks brice-stacks added this to the 3.3.0.0.0 milestone Oct 20, 2025
@brice-stacks brice-stacks linked an issue Oct 20, 2025 that may be closed by this pull request
@brice-stacks brice-stacks requested a review from rdeioris October 20, 2025 16:44
aaronb-stacks
aaronb-stacks previously approved these changes Oct 20, 2025
Copy link

@hugo-stacks hugo-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@rdeioris
Copy link
Contributor

LGTM !just check the comment about utf8 test.

Copy link
Contributor

@aaronb-stacks aaronb-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional comment about tests

Suggestions from PR reviews.
@brice-stacks brice-stacks added this pull request to the merge queue Oct 22, 2025
Merged via the queue into stacks-network:develop with commit 7dc8b45 Oct 22, 2025
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this to Status: ✅ Done in Stacks Core Eng Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.90%. Comparing base (a7d73af) to head (867665b).
⚠️ Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
.../analysis/type_checker/v2_1/natives/conversions.rs 90.90% 3 Missing ⚠️

❌ Your project status has failed because the head coverage (61.90%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (a7d73af) and HEAD (867665b). Click for more details.

HEAD has 80 uploads less than BASE
Flag BASE (a7d73af) HEAD (867665b)
144 64
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6615       +/-   ##
============================================
- Coverage    79.88%   61.90%   -17.99%     
============================================
  Files          571      572        +1     
  Lines       351586   351723      +137     
============================================
- Hits        280856   217720    -63136     
- Misses       70730   134003    +63273     
Files with missing lines Coverage Δ
clarity-types/src/types/signatures.rs 91.98% <100.00%> (-0.69%) ⬇️
...y/src/vm/analysis/type_checker/v2_1/natives/mod.rs 87.59% <100.00%> (-0.61%) ⬇️
...c/vm/analysis/type_checker/v2_1/tests/contracts.rs 63.38% <ø> (-32.36%) ⬇️
...vm/analysis/type_checker/v2_1/tests/conversions.rs 100.00% <100.00%> (ø)
...ity/src/vm/analysis/type_checker/v2_1/tests/mod.rs 61.08% <ø> (-38.76%) ⬇️
.../analysis/type_checker/v2_1/natives/conversions.rs 94.64% <90.90%> (-5.36%) ⬇️

... and 355 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d73af...867665b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[Clarity 4] to-ascii? return type is max-length

6 participants