-
Notifications
You must be signed in to change notification settings - Fork 715
feat: make to-ascii? result type tailored to the input
#6615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make to-ascii? result type tailored to the input
#6615
Conversation
Instead of setting the type of the output to the maximum size for any input, the type-checker now considers the actual type of the input when determining the type of the output. Fixes stacks-network#6582
hugo-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
|
LGTM !just check the comment about utf8 test. |
aaronb-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One additional comment about tests
Suggestions from PR reviews.
7dc8b45
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (61.90%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6615 +/- ##
============================================
- Coverage 79.88% 61.90% -17.99%
============================================
Files 571 572 +1
Lines 351586 351723 +137
============================================
- Hits 280856 217720 -63136
- Misses 70730 134003 +63273
... and 355 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Instead of setting the type of the output to the maximum size for any input, the type-checker now considers the actual type of the input when determining the type of the output.
Fixes #6582