Feat/execution time expired

[rdeioris]

Description

This patch introduces time tracking for contract call.

Initially it is just applied for miners using the "max_execution_time" (seconds) option.

Time is checked at every eval calls and eventually triggers CostErrors::ExecutionTimeExpired

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[obycode]

This looks good! Can you also add a multi-miner integration test where one miner has this new config parameter set to 0? The test should verify that this miner still accepts blocks from the other miner.

[obycode]

This is looking great, just a few more comments.

[kantai]

LGTM!

[obycode]

👍

[codecov]

Codecov Report

Attention: Patch coverage is 97.42198% with 19 lines in your changes missing coverage. Please review.

Project coverage is 84.10%. Comparing base (84c2de2) to head (30f5596).
Report is 42 commits behind head on develop.

Files with missing lines	Patch %	Lines
stackslib/src/chainstate/stacks/miner.rs	73.33%	8 Missing ⚠️
testnet/stacks-node/src/tests/signer/v0.rs	98.69%	4 Missing ⚠️
clarity/src/vm/ast/errors.rs	0.00%	2 Missing ⚠️
clarity/src/vm/clarity.rs	86.66%	2 Missing ⚠️
clarity/src/vm/analysis/errors.rs	50.00%	1 Missing ⚠️
clarity/src/vm/mod.rs	98.00%	1 Missing ⚠️
stackslib/src/config/mod.rs	87.50%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5926      +/-   ##
===========================================
+ Coverage    83.84%   84.10%   +0.26%     
===========================================
  Files          522      522              
  Lines       380644   381318     +674     
  Branches       323      323              
===========================================
+ Hits        319138   320709    +1571     
+ Misses       61498    60601     -897     
  Partials         8        8              

Files with missing lines	Coverage Δ
clarity/src/vm/contexts.rs	92.98% <100.00%> (+0.02%)	⬆️
clarity/src/vm/costs/mod.rs	83.40% <ø> (ø)
clarity/src/vm/tests/simple_apply_eval.rs	99.57% <100.00%> (+<0.01%)	⬆️
stackslib/src/chainstate/coordinator/tests.rs	90.80% <100.00%> (+<0.01%)	⬆️
stackslib/src/chainstate/nakamoto/miner.rs	84.12% <100.00%> (+1.99%)	⬆️
stackslib/src/chainstate/nakamoto/mod.rs	83.86% <100.00%> (-0.03%)	⬇️
stackslib/src/chainstate/nakamoto/shadow.rs	75.75% <100.00%> (+0.03%)	⬆️
stackslib/src/chainstate/nakamoto/tests/node.rs	83.13% <100.00%> (+<0.01%)	⬆️
...kslib/src/chainstate/stacks/boot/contract_tests.rs	93.92% <100.00%> (+0.02%)	⬆️
stackslib/src/chainstate/stacks/db/blocks.rs	89.78% <100.00%> (+0.03%)	⬆️
... and 20 more

... and 43 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31481d...30f5596. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.