Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default mainnet burnchain peer details #5610

Conversation

alexjtupper
Copy link

@alexjtupper alexjtupper commented Dec 22, 2024

Description

On 19th December 2024, the default burnchain peer referenced in the 'mainnet' config of the stacks-node program was taken down. As a result, stacks-node programs run with the 'mainnet' command (i.e. those using the config produced by ConfigFile::mainnet()) no longer sync.

This PR fixes the default mainnet burnchain peer details by updating them to match those in the stacks-blockchain-docker repo.

Applicable issues

(none currently open)

Additional info (benefits, drawbacks, caveats)

To confirm the current configuration doesn't work, you can inspect the DNS result (NXDOMAIN) of running:
dig bitcoin.blockstack.com

Here's the matching stacks-blockchain-docker sample config for mainnet: https://github.com/stacks-network/stacks-blockchain-docker/blob/master/conf/mainnet/Config.toml.sample#L12-L14

The stacks-blockchain-docker config works at the time of writing; confirmed using bitcoin-cli.

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@alexjtupper alexjtupper requested a review from a team as a code owner December 22, 2024 19:08
@CLAassistant
Copy link

CLAassistant commented Dec 22, 2024

CLA assistant check
All committers have signed the CLA.

@alexjtupper alexjtupper changed the title Update default mainnet burnchain peer details to match those in the stacks-blockchain-docker repo Fix default mainnet burnchain peer details Dec 22, 2024
@obycode
Copy link
Contributor

obycode commented Dec 23, 2024

Thanks for the contribution @alexjtupper! This was actually already fixed in develop in #5604, so I'm going to close this one.

@obycode obycode closed this Dec 23, 2024
@alexjtupper
Copy link
Author

Thanks for the contribution @alexjtupper! This was actually already fixed in develop in #5604, so I'm going to close this one.

Perfect! Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants