-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Signer Alongside Node #5495
Conversation
- move most of the release workflow out of `stacks-core` and into `actions`
Overall, looks good! we'll have to coordiante when to merge this (particuarly since there is a composite PR that needs to merge first). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting changes until we can cooridinate when to merge this alongside the actions repo PR.
this is only to prevent accidentally merging before we're ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me!
👍 could you also double-check on the required PR to the actions repo? these two should be merged closely together to reduce disruption: stacks-network/actions#57 |
@wileyj ah I thought I already re-approved in the other PR after reviewing it again, but I didn't. Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
@wileyj could you merge this once you have a moment? |
The aim of this PR is to create a signer release every time there is a core release happening, with the tag set as
<core_release>.0
.This PR also moves most of the release workflow out of
stacks-core
and intoactions
repository such that on subsequent changes to the release process, we can easier adjust the workflows without the need of as manystacks-core
pull requests.I've also implemented
latest
docker image tags on non-RC releases and removed thesigner-
word from the signer version tag as it was redundant.Note: The Actions PR will have to be merged before this can be merged, as it references composite actions that are not existent in the current flow but in the one proposed by that PR.
Example workflows (tests commented out for quicker workflow runs, but they are unaffected by these changes):
4.0.0.0.0
andsigner-4.0.0.0.0.0
releases): https://github.com/BowTiedDevOps/stacks-core/actions/runs/11963198211signer-4.0.0.0.0.1
release): https://github.com/BowTiedDevOps/stacks-core/actions/runs/11963781406signer-4.0.0.0.0.2-rc1
release, used to test that docker imagelatest
doesn't update on RC builds): https://github.com/BowTiedDevOps/stacks-core/actions/runs/11963969804Useful Links:
Binaries Version Check:
Docker Images Version Check: