Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Signer Alongside Node #5495

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Conversation

BowTiedDevOps
Copy link
Collaborator

The aim of this PR is to create a signer release every time there is a core release happening, with the tag set as <core_release>.0.

This PR also moves most of the release workflow out of stacks-core and into actions repository such that on subsequent changes to the release process, we can easier adjust the workflows without the need of as many stacks-core pull requests.

I've also implemented latest docker image tags on non-RC releases and removed the signer- word from the signer version tag as it was redundant.

Note: The Actions PR will have to be merged before this can be merged, as it references composite actions that are not existent in the current flow but in the one proposed by that PR.

Example workflows (tests commented out for quicker workflow runs, but they are unaffected by these changes):

Useful Links:

Binaries Version Check:

  • Node Release
    $ ./stacks-node version
    INFO [1732236056.645827] [testnet/stacks-node/src/main.rs:283] [main] stacks-node 4.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, 
    release build, linux [x86_64])
    stacks-node 4.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, release build, linux [x86_64])
    
    $ ./stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, release build, linux [x86_64])
  • Signer Release Built Alongside Node
    $ ./stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, release build, linux [x86_64])
  • Standalone Signer Release:
    $ ./stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.1 (release/signer-4.0.0.0.0.1:eb8aaf7, release build, linux [x86_64])
  • Standalone Signer Release (RC Build):
    $ ./stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.2-rc1 (release/signer-4.0.0.0.0.2-rc1:eb8aaf7, release build, linux [x86_64])

Docker Images Version Check:

  • Node
    $ docker run bowtieddevops/stacks-core:4.0.0.0.0 stacks-node version
    stacks-node 4.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, release build, linux [x86_64])
    INFO [1732236172.154954] [testnet/stacks-node/src/main.rs:283] [main] stacks-node 4.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, 
    release build, linux [x86_64])
    
    $ docker run bowtieddevops/stacks-core:latest stacks-node version
    INFO [1732236216.647136] [testnet/stacks-node/src/main.rs:283] [main] stacks-node 4.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, 
    release build, linux [x86_64])
    stacks-node 4.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, release build, linux [x86_64])
  • Signer
    $ docker run bowtieddevops/stacks-signer:4.0.0.0.0.0 stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, release build, linux [x86_64])
    
    $ docker run bowtieddevops/stacks-signer:4.0.0.0.0.1 stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.1 (release/signer-4.0.0.0.0.1:eb8aaf7, release build, linux [x86_64])
    
    $ docker run bowtieddevops/stacks-signer:4.0.0.0.0.2-rc1 stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.2-rc1 (release/signer-4.0.0.0.0.2-rc1:eb8aaf7, release build, linux [x86_64])
    
    $ docker run bowtieddevops/stacks-signer:latest stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.1 (release/signer-4.0.0.0.0.1:eb8aaf7, release build, linux [x86_64])

- move most of the release workflow out of `stacks-core` and into `actions`
@BowTiedDevOps BowTiedDevOps added enhancement Iterations on existing features or infrastructure. CI labels Nov 22, 2024
@BowTiedDevOps BowTiedDevOps self-assigned this Nov 22, 2024
@BowTiedDevOps BowTiedDevOps requested a review from a team as a code owner November 22, 2024 01:23
@wileyj wileyj added this to the 3.1.0.0.2 milestone Dec 11, 2024
@wileyj
Copy link
Contributor

wileyj commented Dec 11, 2024

Overall, looks good! we'll have to coordiante when to merge this (particuarly since there is a composite PR that needs to merge first).

Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes until we can cooridinate when to merge this alongside the actions repo PR.
this is only to prevent accidentally merging before we're ready

Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! :shipit:

@wileyj
Copy link
Contributor

wileyj commented Dec 19, 2024

Seems good to me! :shipit:

👍 could you also double-check on the required PR to the actions repo? these two should be merged closely together to reduce disruption: stacks-network/actions#57

@CharlieC3
Copy link
Member

@wileyj ah I thought I already re-approved in the other PR after reviewing it again, but I didn't. Done!

Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@wileyj wileyj enabled auto-merge December 30, 2024 16:36
@wileyj wileyj self-requested a review December 30, 2024 16:38
@aldur
Copy link
Contributor

aldur commented Jan 7, 2025

@wileyj could you merge this once you have a moment?

@wileyj wileyj modified the milestones: 3.1.0.0.4, 3.1.0.0.3 Jan 8, 2025
@kantai kantai modified the milestones: 3.1.0.0.3, 3.1.0.0.4 Jan 9, 2025
@wileyj wileyj disabled auto-merge January 10, 2025 15:29
@wileyj wileyj enabled auto-merge January 10, 2025 15:30
@wileyj wileyj added this pull request to the merge queue Jan 10, 2025
Merged via the queue into stacks-network:develop with commit f4db3c9 Jan 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement Iterations on existing features or infrastructure.
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants