Chore/cache timestamp calc #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
…previous) into tenure_blocks Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
hstove
reviewed
Nov 22, 2024
Base automatically changed from
chore/ignore-stx-transfer-blocks
to
feat/time-based-tenure-extend
November 22, 2024 15:42
…acks-network/stacks-core into chore/cache-timestamp-calc
…ecution cost of block validation Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
jcnelson
reviewed
Nov 22, 2024
jcnelson
reviewed
Nov 22, 2024
jcnelson
reviewed
Nov 22, 2024
hstove
requested changes
Nov 22, 2024
…acks-network/stacks-core into chore/cache-timestamp-calc
…ock info extracted Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
obycode
reviewed
Nov 26, 2024
obycode
reviewed
Nov 26, 2024
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
hstove
requested changes
Nov 26, 2024
You are right! I missed it when converting to use the same table! |
…et_tenure_times Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
jcnelson
reviewed
Nov 26, 2024
| DROP TABLE blocks; | ||
|
|
||
| ALTER TABLE temp_blocks RENAME TO blocks;"#; | ||
|
|
jcnelson
reviewed
Nov 26, 2024
jcnelson
reviewed
Nov 26, 2024
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
hstove
approved these changes
Nov 26, 2024
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally tried to create a db that just tracked a cumulative tenure processing time that would reset each time a new tenure change payload arrived, but these had a lot of edge cases due to out of order blocks. Hank suggested keeping a much smaller db copy of blocks to determine the tenure processing time instead which was much cleaner. I also implemented a cleanup for it since technically this is redundant/heuristic info and don't think we should have to keep it around indefinitely like we do other signer data.