Fix/5249 #5253
Merged
Fix/5249 #5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate between (and including) the new and old tips, since cached data from the old tip will have stored a negative cache result that ought now to be positive in the context of the new tip.
|
Don't let the line count scare you. The fix is very small; over 90% of the new lines are tests. |
…tent with no-caching behavior
jferrant
reviewed
Sep 30, 2024
kantai
reviewed
Sep 30, 2024
jferrant
previously approved these changes
Oct 1, 2024
|
I think this is okay, but i have never seen tests::nakamoto_integrations::continue_tenure_extend fail before so wonder if its an issue with this branch...EDIT: I ran it locally in develop and your branch and both pass so I guess this is just a new flakey test. XD |
…n terminate the downloader (so we can try again later)
hstove
reviewed
Oct 2, 2024
|
Confirmed that running this on my Nakamoto Testnet node has fixed the issue of not being able to catch all the way back up to the tip |
kantai
reviewed
Oct 3, 2024
kantai
reviewed
Oct 3, 2024
hstove
previously approved these changes
Oct 3, 2024
obycode
reviewed
Oct 3, 2024
obycode
previously approved these changes
Oct 3, 2024
hstove
approved these changes
Oct 3, 2024
obycode
approved these changes
Oct 3, 2024
kantai
approved these changes
Oct 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5249. The bug was that we were not invalidating cached negatives (i.e. marking the absence of a tenure) when the Nakamoto tip advanced. As a result, tenures that did not yet exist as of the Nakamoto tip when the cache was initially populated, but later came into existence, would never be reported in the inventory vector.
Leaving this as a draft until I can add some more test coverage.