Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: RBF mempool behavior #5210

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Fix: RBF mempool behavior #5210

merged 4 commits into from
Sep 19, 2024

Conversation

wileyj
Copy link
Contributor

@wileyj wileyj commented Sep 18, 2024

add changelog and test

@wileyj wileyj requested review from a team as code owners September 18, 2024 20:01
jcnelson
jcnelson previously approved these changes Sep 18, 2024
View reviewed changes
@wileyj wileyj mentioned this pull request Sep 18, 2024
Merged
obycode
obycode previously approved these changes Sep 18, 2024
View reviewed changes
wileyj added a commit that referenced this pull request Sep 18, 2024
@wileyj
adding test from #5210
89c1414
@wileyj wileyj dismissed stale reviews from obycode and jcnelson via 3804523 September 18, 2024 20:08
obycode
obycode previously approved these changes Sep 18, 2024
View reviewed changes
@kantai kantai changed the title add changelog and test Fix: RBF mempool behavior Sep 19, 2024
@wileyj
Copy link
Contributor Author

wileyj commented Sep 19, 2024

failing test is passing locally

        PASS [ 114.403s] stacks-node::bin/stacks-node tests::epoch_25::microblocks_disabled

obycode
obycode approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saralab saralab merged commit bed29bc into release/2.5.0.0.7 Sep 19, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obycode obycode obycode approved these changes

@jcnelson jcnelson jcnelson approved these changes

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wileyj @blockstack-devops @jcnelson @obycode @saralab @kantai