Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/signer block state machine #5173

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

jferrant
Copy link
Collaborator

Cleaning up some spammy logs due to moving from existing state to an existing state. This is legal and happens frequently enough. This allows this conversion and also makes sure that internal state does not change if the block state fails to update.

… same state and add tests

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant requested a review from a team as a code owner September 12, 2024 18:30
@obycode
Copy link
Contributor

obycode commented Sep 13, 2024

Approved, but please check the failing tests.

@jferrant jferrant merged commit 36acc33 into fix/5136-node-and-miner Sep 13, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants