Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create signer_bug Issue Template #5086

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Create signer_bug Issue Template #5086

merged 4 commits into from
Aug 19, 2024

Conversation

will-corcoran
Copy link
Contributor

@will-corcoran will-corcoran commented Aug 19, 2024 •
edited by BowTiedDevOps
Loading

Adding an issue template for Signers to submit bugs and issues with the Signer

Description

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@will-corcoran
Create signer_bug
ee79291 
Adding an issue template for Signers to submit bugs and issues with the Signer
@will-corcoran will-corcoran requested a review from a team as a code owner August 19, 2024 15:57
@BowTiedDevOps
Copy link
Contributor

Also, the file needs to have a markdown extension:

- .github/ISSUE_TEMPLATE/signer_bug
+ .github/ISSUE_TEMPLATE/signer_bug.md

@will-corcoran will-corcoran changed the title Create signer_bug Create signer_bug Issue Template Aug 19, 2024
@will-corcoran @BowTiedDevOps
Update .github/ISSUE_TEMPLATE/signer_bug
7fb27ff 
Co-authored-by: BowTiedDevOps <157840260+BowTiedDevOps@users.noreply.github.com>
will-corcoran
will-corcoran commented Aug 19, 2024
View reviewed changes
Copy link
Contributor Author

@will-corcoran will-corcoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@will-corcoran @BowTiedDevOps
Update .github/ISSUE_TEMPLATE/signer_bug.md
79f3a2f 
LGTM

Co-authored-by: BowTiedDevOps <157840260+BowTiedDevOps@users.noreply.github.com>
wileyj
wileyj approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

BowTiedDevOps
BowTiedDevOps approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@BowTiedDevOps BowTiedDevOps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

obycode
obycode approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wileyj wileyj merged commit a643308 into master Aug 19, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 28, 2024
@wileyj wileyj deleted the will-corcoran-patch-1 branch March 11, 2025 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obycode obycode obycode approved these changes

@wileyj wileyj wileyj approved these changes

@BowTiedDevOps BowTiedDevOps BowTiedDevOps approved these changes

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@will-corcoran @BowTiedDevOps @blockstack-devops @obycode @wileyj