Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/4950 signers terminate tenure early #4952

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Fix/4950 signers terminate tenure early #4952

merged 7 commits into from
Jul 10, 2024

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented Jul 8, 2024 •
edited
Loading

Closes #4950

@jferrant jferrant requested review from a team as code owners July 8, 2024 18:53
jferrant added 2 commits July 9, 2024 08:05
@jferrant
Do not terminate tenure early and process block proposals that are fr…
830c636 
…om prior cycles. Adds test.

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant
Cleanup logging and cleanup_stale_signers
f90bb29 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant force-pushed the fix/4950-signers-terminate-tenure-early branch from 5407756 to f90bb29 Compare July 9, 2024 12:05
jferrant added 2 commits July 9, 2024 08:07
@jferrant
Cleanup has_pending_blocks documentation
bce9dd2 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant
Add end_of_tenure test to CI
224273b 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant requested a review from a team as a code owner July 9, 2024 12:48
@saralab saralab requested a review from kantai July 9, 2024 13:48
obycode
obycode previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jferrant
Remove sleeps in end_of_tenure test
86d6d22 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant requested a review from obycode July 9, 2024 14:53
@jferrant
Fix waiting for burn blocks logic
b231ee9 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant requested a review from obycode July 9, 2024 16:31
obycode
obycode previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hstove
hstove previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small note on the has_pending_blocks test but that's pretty minor, and the integration test covers the scenario very well, so LGTM!

stacks-signer/src/signerdb.rs Show resolved Hide resolved
@wileyj wileyj enabled auto-merge July 9, 2024 22:52
@jferrant
Fix has_pending_blocks test
25ca77e 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant dismissed stale reviews from hstove and obycode via 25ca77e July 10, 2024 13:27
@jferrant jferrant requested review from hstove and obycode July 10, 2024 13:28
@wileyj wileyj added this pull request to the merge queue Jul 10, 2024
Merged via the queue into develop with commit 108bf0e Jul 10, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obycode obycode obycode approved these changes

@hstove hstove hstove approved these changes

@kantai kantai Awaiting requested review from kantai

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jferrant @blockstack-devops @hstove @obycode @wileyj