Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix block reward check in check_block_info_rewards #4928

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Jun 28, 2024

Fixes integration test tests::nakamoto_integrations::check_block_info_rewards.

@obycode obycode requested a review from a team as a code owner June 28, 2024 18:27
@obycode obycode requested a review from wileyj June 28, 2024 18:28
jferrant
jferrant previously approved these changes Jun 28, 2024
@wileyj
Copy link
Contributor

wileyj commented Jun 28, 2024

related issue #4887

@wileyj
Copy link
Contributor

wileyj commented Jun 28, 2024

expected, but this change does allow the test to pass:

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 151 filtered out; finished in 1186.00s

@obycode obycode requested a review from a team as a code owner July 10, 2024 20:08
@obycode obycode requested review from jferrant, kantai and jcnelson July 10, 2024 20:10
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@wileyj wileyj enabled auto-merge July 11, 2024 15:31
@wileyj wileyj added this pull request to the merge queue Jul 11, 2024
Merged via the queue into develop with commit 87fec3d Jul 11, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants