Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/tenure extend transactions #4827

Merged
merged 15 commits into from
Jun 20, 2024
Merged

Feat/tenure extend transactions #4827

merged 15 commits into from
Jun 20, 2024

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented May 29, 2024 •
edited
Loading

Closes #4709

jferrant added 2 commits May 28, 2024 09:21
@jferrant
Add MinerReason to a spawned thread to trigger a tenure extend
d96e65d 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant
Move continue tenure logic to seperate function that passes up errors
aa71172 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant requested a review from a team as a code owner May 29, 2024 11:26
@jferrant jferrant marked this pull request as draft May 29, 2024 12:46
@jferrant
WIP: add a test for continue tenure
a84819a 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant force-pushed the feat/tenure-extend-transactions branch from 0f67c5b to a84819a Compare May 30, 2024 17:11
@jferrant
WIP: no idea what I am doing
73eacae 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant force-pushed the feat/tenure-extend-transactions branch from a39318d to 73eacae Compare June 4, 2024 16:49
jferrant added 6 commits June 4, 2024 14:17
@jferrant
WIP: burnchain tip has changed
2f0d7cd 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant
WIP: burnchain tip has changed due to not using selected burn block
ed15f3b 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant
WIP: cargo fmt stuff
a2c0553 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant
WIP: Can't figure out why block election snapshot does not match betw…
ff40a27 
…een new block tenure and following continue tenure

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant
WIP: fetch the bitcoin snapshot that elected the current canconical tip
27e206c 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant
Fix test to only care about the 15 tenures we mine
2d32ba0 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant force-pushed the feat/tenure-extend-transactions branch from 23456e3 to 2d32ba0 Compare June 6, 2024 13:34
@jferrant jferrant marked this pull request as ready for review June 6, 2024 13:47
@jferrant jferrant requested a review from a team as a code owner June 6, 2024 13:47
@saralab saralab changed the title WIP: Feat/tenure extend transactions Feat/tenure extend transactions Jun 6, 2024
@saralab saralab requested review from jcnelson, kantai and obycode June 6, 2024 13:50
jferrant added 2 commits June 6, 2024 10:11
@jferrant
Fix bad merge
309cafe 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant
Cleanup stale data from prior commits
24b5e79 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant
CRC: use the last snapshot with a sortition to determine if we should…
8281f17 
… proceed with a continue_tenure

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant force-pushed the feat/tenure-extend-transactions branch from 55ae4df to 8281f17 Compare June 17, 2024 17:31
@jferrant
CRC: update continue tenure extend to include a check for block found…
11a6262 
… tenure reasons

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
kantai
kantai approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

@jferrant jferrant requested a review from jcnelson June 20, 2024 18:04
obycode
obycode approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! it doesn't need to be part of this PR, but reading through this made me think how nice it would be for devs to see a flowchart for a miner. Maybe added in markdown at the top of nakamoto_node/miner.rs or something?

@jferrant jferrant mentioned this pull request Jun 20, 2024
Open
@jferrant
Copy link
Collaborator Author

This looks good! it doesn't need to be part of this PR, but reading through this made me think how nice it would be for devs to see a flowchart for a miner. Maybe added in markdown at the top of nakamoto_node/miner.rs or something?

Added issue for it: #4897

@jferrant jferrant enabled auto-merge June 20, 2024 18:43
@jferrant jferrant added this pull request to the merge queue Jun 20, 2024
Merged via the queue into develop with commit 150ac0d Jun 20, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kantai kantai kantai approved these changes

@obycode obycode obycode approved these changes

@jcnelson jcnelson Awaiting requested review from jcnelson

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jferrant @blockstack-devops @jcnelson @kantai @obycode