fix: try not deleting accepted blocks from signerDB #4514
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dream-team-fixes #4514 +/- ##
====================================================
- Coverage 83.23% 82.83% -0.40%
====================================================
Files 452 452
Lines 326113 326161 +48
Branches 323 323
====================================================
- Hits 271436 270177 -1259
- Misses 54669 55976 +1307
Partials 8 8
... and 33 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| // TODO: proper garbage collection...This is currently our only cleanup of blocks | ||
| self.signer_db | ||
| .remove_block(&block_vote.signer_signature_hash) | ||
| .expect(&format!("{self}: Failed to remove block from to signer DB")); | ||
| // WIP: try not deleting a block from signerDB until we have a better garbage collection strategy. | ||
| // This causes issues when we have to reprocess a block and we have already deleted it from the signerDB | ||
| // // TODO: proper garbage collection...This is currently our only cleanup of blocks | ||
| // self.signer_db | ||
| // .remove_block(&block_vote.signer_signature_hash) | ||
| // .expect(&format!("{self}: Failed to remove block from to signer DB")); |
There was a problem hiding this comment.
Yep -- I'd advocate just dropping this line permanently (no need to comment out). Now that this information is stored in a file, I don't think that there's a strong need to clean this state up.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
In looking at testnet logs, I've seen that we hit scenarios where a block is saved as "accepted", which deletes the block from SignerDB, and then shortly later the signer tries to process the block, but the signer has no about the block (because it's deleted).