Nakamoto-Node: Support for interim block mining #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcnelson
reviewed
Dec 18, 2023
jcnelson
reviewed
Dec 18, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #4187 +/- ##
===========================================
- Coverage 85.08% 65.52% -19.57%
===========================================
Files 429 429
Lines 302009 302067 +58
===========================================
- Hits 256976 197933 -59043
- Misses 45033 104134 +59101 ☔ View full report in Codecov by Sentry. |
jcnelson
approved these changes
Dec 18, 2023
|
The code coverage drop seems to be due to tests which aren't run on PRs, but are run on the base branch (e.g., the epoch tests). The patch coverage is 90%. |
jferrant
reviewed
Dec 19, 2023
jferrant
reviewed
Dec 19, 2023
jferrant
approved these changes
Dec 19, 2023
…check to stackslib::miner assembly. chore: fix typo
kantai
force-pushed
the
feat/interim-mining
branch
from
24a4cda to
3cef3b4
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to the nakamoto node for interim block mining (i.e., blocks within the current tenure) with a configurable wait time between such blocks. This PR also refactors the
chainstate::nakamoto::minermodule to match the actual usage of the miner interfaces, and moving theTestPeerspecific method out intoTestPeeritself.This adds a new
nakamoto_integrationtest which mines 10 nakamoto tenures, each with 2 blocks in the tenure.