-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarity Wasm Next #4093
Closed
Closed
Clarity Wasm Next #4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crate already pulled by the clarity vm crate, and only used there.
Handle passing arguments into a contract call using the Wasm runtime and handle returning a value from the contract call.
The pass that initializes a contract should have the contract analysis available, but when a contract is being called, only use the `ContractContext`. This requires adding the return type of a function to this context.
This comment clarifies that this function should not be used during normal execution.
All error cases should be properly handled and generate an error to be handled by the caller. Any `Wasm` errors should never happen in production and would indicate an implementation problem if they show up.
Co-authored-by: Acaccia <anthonycaccia24@gmail.com>
This is to allow moving stacks-blockchain into clarity-wasm as a submodule.
…o-memory-value Clarity-wasm: fix computation of in-memory size
Superseded by #4756 |
Draft
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the changes used for clarity-wasm. It may not yet be ready to be merged, but the clarity-wasm team is reviewing it as we go and then it will need a thorough review once it is ready to be merged into
next
.This branch supersedes #3880 and the previous branch that was used by clarinet. The clarinet specific changes (to make the clarity crate compilable to wasm) are the starting point for the clarity-wasm changes.