Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logic bug in mocknet/helium miner #2710 #2711

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Conversation

kantai
Copy link
Contributor

@kantai kantai commented Jun 14, 2021

This fixes #2710 -- the mocknet/helium miner had a logic bug that would lead to a panic if a burn block occurred without a sortition in it.

Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kantai kantai requested a review from lgalabru June 14, 2021 18:23
Copy link
Contributor

@pavitthrap pavitthrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the quick fix @kantai

@kantai kantai merged commit 02ecae6 into develop Jun 15, 2021
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 22, 2024
@kantai kantai deleted the fix/2710-mocknet branch March 10, 2025 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants