Skip to content

[nakamoto] Bug in /v2/neighbors #5172

Closed
@diwakergupta

Description

@diwakergupta

Copying over from Nakamoto Slack, as reported by @jcnelson:

There's a bug in /v2/neighbors -- it's reporting all neighbors whose last-contact time is greater than self.connection_opts.max_neighbor_age (which is sometime in January 1970 if taken as an absolute UNIX timestamp), whereas the p2p interfaces all use get_epoch_time_secs() - self.connection_opts.max_neighbor_age (which is correct). self.connection_opts.max_neighbor_age is set to 3 days. Some addresses reported in /v2/neighbors may be dead

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Status: ✅ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions