Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nakamoto] Bug in /v2/neighbors #5172

Closed
diwakergupta opened this issue Sep 12, 2024 · 1 comment
Closed

[nakamoto] Bug in /v2/neighbors #5172

diwakergupta opened this issue Sep 12, 2024 · 1 comment
Assignees
Labels

Comments

@diwakergupta
Copy link
Member

Copying over from Nakamoto Slack, as reported by @jcnelson:

There's a bug in /v2/neighbors -- it's reporting all neighbors whose last-contact time is greater than self.connection_opts.max_neighbor_age (which is sometime in January 1970 if taken as an absolute UNIX timestamp), whereas the p2p interfaces all use get_epoch_time_secs() - self.connection_opts.max_neighbor_age (which is correct). self.connection_opts.max_neighbor_age is set to 3 days. Some addresses reported in /v2/neighbors may be dead

@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Sep 12, 2024
@diwakergupta diwakergupta changed the title [nakamoto] Bug in /v2/neighors [nakamoto] Bug in /v2/neighbors Sep 12, 2024
@jcnelson jcnelson self-assigned this Sep 12, 2024
@saralab saralab moved this from Status: 🆕 New to Status: ✅ Done in Stacks Core Eng Sep 17, 2024
@saralab saralab closed this as completed Sep 17, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Status: ✅ Done
Development

No branches or pull requests

4 participants