Skip to content

ROX-29674: Sync caBundle changes to ValidatingWebhookConfiguration #15706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vladbologa
Copy link
Contributor

@vladbologa vladbologa commented Jun 12, 2025

Description

WIP, doesn't really work yet.

Try to propagate CA bundle changes from a ConfigMap that Sensor manages to the ValidatingWebhookConfiguration of the Admission Controller. This is so that admission-control can still function if its leaf certificate is rotated and it is now signed by a different CA than the original one (used at installation time).

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

Copy link

openshift-ci bot commented Jun 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vladbologa vladbologa changed the title ROX-29674: Propagate CA bundle changes to the ValidatingWebhookConfiguration ROX-29674: Sync caBundle changes to ValidatingWebhookConfiguration Jun 12, 2025
@vladbologa vladbologa force-pushed the vb/admission-control-ca-bundle-reconciler branch from fd7db5a to 4abe2bb Compare June 12, 2025 12:19
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jun 12, 2025

Images are ready for the commit at 5e83358.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-49-g5e83358df6.

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 48.78%. Comparing base (993dbb5) to head (5e83358).

Files with missing lines Patch % Lines
...extensions/reconcile_admissioncontrol_ca_bundle.go 0.00% 47 Missing ⚠️
operator/internal/utils/predicates.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15706      +/-   ##
==========================================
- Coverage   48.79%   48.78%   -0.01%     
==========================================
  Files        2590     2591       +1     
  Lines      190492   190550      +58     
==========================================
+ Hits        92957    92969      +12     
- Misses      90236    90283      +47     
+ Partials     7299     7298       -1     
Flag Coverage Δ
go-unit-tests 48.78% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vladbologa vladbologa force-pushed the vb/admission-control-ca-bundle-reconciler branch 2 times, most recently from 54ae54e to ec4110a Compare June 12, 2025 14:38
@vladbologa vladbologa force-pushed the vb/admission-control-ca-bundle-reconciler branch from ec4110a to 5e83358 Compare June 12, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants