-
Notifications
You must be signed in to change notification settings - Fork 157
chore: bump helm-operator fork to new rebase #14233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request. |
Images are ready for the commit at 4721599. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14233 +/- ##
=======================================
Coverage 49.08% 49.08%
=======================================
Files 2514 2514
Lines 182769 182769
=======================================
+ Hits 89705 89707 +2
+ Misses 85944 85943 -1
+ Partials 7120 7119 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/test all |
/retest |
2 similar comments
/retest |
/retest |
Images are ready for the commit at 36821dd. To use with deploy scripts, first |
Looks like the test is passing but the cluster destroy is failing.
|
4721599
to
36821dd
Compare
Images are ready for the commit at bff1abc. To use with deploy scripts, first |
36821dd
to
bff1abc
Compare
Description
Our changes to helm-operator were rebased on top of the most recent release. This change switches to using this code.
This also happens to bump the k8s libraries.
In this repo, one minor change to a function was needed due to a slightly incompatible controller-runtime API change.
In the helm-operator repo, there were more changes needed due to more strict lint checking. Please review them in the context of this PR.
Most differences are due to differing context. Actual changes to the code made during the rebase were in patches:
Failed
toFailds
in a few places to reduce the constant reformatting churn - when upstreaming we'll need to change this to correct spelling, but for now it's just a PITA;nolint:unparam
added inhandlePending
to silence overzealous "first value returned is always nil" warning; error message formatting due to linter complaintswatchDescription
Also a round of
make -C operator generate manifests bundle
was needed.Yet another change was needed to compliance operator test do deal with a breaking change in controller runtime.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI is enough.