Skip to content

CI: Cleanup dangling processes #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 18, 2022
Merged

CI: Cleanup dangling processes #980

merged 11 commits into from
Oct 18, 2022

Conversation

RTann
Copy link
Collaborator

@RTann RTann commented Oct 17, 2022

See stackrox/stackrox#3440 for equivalent PR in the stackrox repo

@RTann RTann requested a review from gavin-stackrox October 17, 2022 18:40
@RTann
Copy link
Collaborator Author

RTann commented Oct 17, 2022

/retest

@ghost
Copy link

ghost commented Oct 17, 2022 •
edited by ghost
Loading

Images are ready for the commit at ccb0696.

To use the images, use the tag 2.26-49-gccb0696bb9.

@RTann
Copy link
Collaborator Author

RTann commented Oct 17, 2022

/retest

@RTann RTann requested review from c-du and daynewlee October 17, 2022 20:46
RTann
RTann commented Oct 17, 2022
View reviewed changes
@RTann
Copy link
Collaborator Author

RTann commented Oct 17, 2022

@gavin-stackrox Tests keep failing because ps is not installed. The issue is a lot of these steps in CI are based on the src image which does not have ps. I see stackrox uses test-bin. Can you tell me more about this image?

@gavin-stackrox
Copy link
Contributor

  • src == build_root + the cloned repo
  • test-bin == src + whatever test-binary-build-commands create (IIRC)

I think you are hitting the problem that build_root is reconciled from master and not your PR. There is a painful update validation process detailed in https://github.com/stackrox/scanner/blob/master/.openshift-ci/Dockerfile.build_root. You could also go YOLO and revert if the merge CI fails horribly.

gavin-stackrox
gavin-stackrox approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@gavin-stackrox gavin-stackrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the new build_root is not tested by this PR as mentioned earlier.

RTann and others added 3 commits October 17, 2022 16:53
@RTann @gavin-stackrox
Update scripts/ci/lib.sh
16573b6 
Co-authored-by: Gavin Jefferies <gavin@stackrox.com>
@RTann
forgot import
ccad681
@RTann
Merge branch 'ross/handle_dangling_processes' of github.com:stackrox/…
ccb0696 
…scanner into ross/handle_dangling_processes
@RTann RTann merged commit 392d114 into master Oct 18, 2022
@RTann RTann deleted the ross/handle_dangling_processes branch October 18, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavin-stackrox gavin-stackrox gavin-stackrox approved these changes

@c-du c-du Awaiting requested review from c-du

@daynewlee daynewlee Awaiting requested review from daynewlee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RTann @gavin-stackrox