fix tag used for hourly CI runs

[RTann]

I noticed "hourly" CI runs are pushing images with the nightly tag. I think this is because we set CIRCLE_TAG to git tag --sort=creatordate --contains | tail -1. I think if there have not been any merges to the master branch since the nightly ran, then this will return a nightly tag. For example, running this on the master branch right now gave me 2.26-nightly-20220930.

This PR removes CIRCLE_JOB and CIRCLE_TAG and replaces CIRCLE_TAG with NIGHTLY_TAG

[ghost]

Images are ready for the commit at 0e491b1.

To use the images, use the tag 2.26-27-g0e491b16e3.

[gavin-stackrox]

LGTM if this works for you but I think the change alters the meaning of CIRCLE_TAG which might cause confusion. It will now always be set. In the Circle CI world this was used only with CI that was triggered by the addition of a tag. Which was releases, rcs, nightlies.

[RTann]

LGTM if this works for you but I think the change alters the meaning of CIRCLE_TAG which might cause confusion. It will now always be set. In the Circle CI world this was used only with CI that was triggered by the addition of a tag. Which was releases, rcs, nightlies.

That's what I was thinking, but I noticed that git tag --sort=creatordate --contains | tail -1 returns a nightly tag, so it's possible this has been getting set by accident already?

[gavin-stackrox]

LGTM if this works for you but I think the change alters the meaning of CIRCLE_TAG which might cause confusion. It will now always be set. In the Circle CI world this was used only with CI that was triggered by the addition of a tag. Which was releases, rcs, nightlies.

That's what I was thinking, but I noticed that git tag --sort=creatordate --contains | tail -1 returns a nightly tag, so it's possible this has been getting set by accident already?

I think with stackrox/stackrox using --contains works ok because there is no automation that runs on a cron against the main branch.

[RTann]

@gavin-stackrox I updated it to set a new NIGHTLY_TAG and I removed CIRCLE_TAG since it's not really used (especially not as widely used as it is in the stackrox repo). Let me know if this makes more sense now, thanks

[gavin-stackrox]

Makes sense to me.

[openshift-ci]

@RTann: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-tests	0e491b1	link	false	/test e2e-tests
ci/prow/slim-e2e-tests	0e491b1	link	false	/test slim-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.