Skip to content

Update stackrox/stackrox dependency #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Conversation

RTann
Copy link
Collaborator

@RTann RTann commented Sep 27, 2022

Our dependency was a bit dated, which, from a functionality standpoint, is ok, but this will also resolve vulnerabilities which have since been patched in dependencies.

@ghost
Copy link

ghost commented Sep 27, 2022

Images are ready for the commit at 1e9b3d5.

To use the images, use the tag 2.26-24-g1e9b3d5bc2.

@RTann
Copy link
Collaborator Author

RTann commented Sep 27, 2022

Verified if we were to update the version of scanner in stackrox's go.mod there will be no dependency issues.

Copy link
Contributor

@misberner misberner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In stackrox/stackrox, I once added an exclude directive to break the cycle of dependencies early, just to give go mod tidy less work. It's possible that this is no longer required in a newer go version - can you check whether adding exclude github.com/stackrox/scanner <version imported by respective rox version> has any material impact on the runtime of go mod tidy or the size of go.sum?

@RTann
Copy link
Collaborator Author

RTann commented Sep 27, 2022

@misberner I added exclude github.com/stackrox/scanner v0.0.0-20220426001230-9ab6777c9581 to my go.mod just now, and I saw no change to the go.sum. I also searched the go.sum file for any reference to scanner, but I did not find anything, so it looks like adding the exclude doesn't do much

@RTann RTann requested a review from misberner September 27, 2022 23:20
Copy link
Contributor

@misberner misberner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah LG. The go folks added some module pruning to the resolution algorithm in 1.16 or 1.17, that's probably it.

@RTann RTann merged commit 58834cc into master Sep 28, 2022
@RTann RTann deleted the ross/update-stackrox-dep-09272022 branch September 28, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants