Refactor common detection function to its own package #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvdm
force-pushed
the
jvdm/12238/4/pull
branch
from
e62d6aa to
ed91805
Compare
|
Images are ready for the commit at a0baafe. To use the images, use the tag |
jvdm
force-pushed
the
jvdm/12238/3/pull
branch
from
7b2b835 to
c123b7a
Compare
jvdm
force-pushed
the
jvdm/12238/4/pull
branch
from
ed91805 to
ad38365
Compare
jvdm
force-pushed
the
jvdm/12238/4/pull
branch
from
ad38365 to
a0baafe
Compare
RTann
approved these changes
Sep 9, 2022
| // layers, or the root layer, use `nil`. Notice that language components are not | ||
| // extracted by DetectComponents, but if provided they are annotated with | ||
| // certified RHEL dependencies, and returned. | ||
| func DetectComponents(name string, files analyzer.Files, parent *database.Layer, languageComponents []*component.Component, uncertifiedRHEL bool) (*database.Namespace, []database.FeatureVersion, *database.RHELv2Components, []*component.Component, error) { |
There was a problem hiding this comment.
I'm assuming this is simply copy/pasted (aside from the function's rename)?
There was a problem hiding this comment.
Moved around the name to be the first parameter to match DetectNamespace. Other than that, yes, this is a copy'n'paste.
|
Approved assuming it's a simple copy/paste |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by Cong in #911 this PR move the basic detection methods out of
stackrox/scannerinto a separate package belowpkg(in this case,pkg/analyzer/detection).