Skip to content

Comments

fix(ci): add specific psql version to fix s390x#2092

Merged
BradLugo merged 1 commit intomasterfrom
blugo/fix-s390x-psql-build
Aug 27, 2025
Merged

fix(ci): add specific psql version to fix s390x#2092
BradLugo merged 1 commit intomasterfrom
blugo/fix-s390x-psql-build

Conversation

@BradLugo
Copy link
Contributor

@BradLugo BradLugo commented Aug 26, 2025

No description provided.

@BradLugo BradLugo requested a review from a team as a code owner August 26, 2025 21:54
@openshift-ci
Copy link

openshift-ci bot commented Aug 26, 2025

@BradLugo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 3e46dde link false /test e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@daynewlee
Copy link
Contributor

daynewlee commented Aug 27, 2025 •
edited
Loading

I am not an expert of this, do we have to worry about the Konflux build failures?

daynewlee
daynewlee reviewed Aug 27, 2025
View reviewed changes
Copy link
Contributor

@daynewlee daynewlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor question

@daynewlee daynewlee requested review from RTann, dcaravel and jvdm August 27, 2025 03:18
dcaravel
dcaravel approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@dcaravel dcaravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcaravel
Copy link
Contributor

dcaravel commented Aug 27, 2025 •
edited
Loading

I am not an expert of this, do we have to worry about the Konflux build failures?

Good Q - my 2 cents - since upstream images and CI do not use anything from Konflux - this at least fixes upstream.

Looks like both downstream and konflux use registry.redhat.io/rhel8/postgresql-15 as a base, which appears to not depend on the download.sh for downloading postgres - so may be unaffected.

@BradLugo BradLugo force-pushed the blugo/fix-s390x-psql-build branch from 3e46dde to a4491fd Compare August 27, 2025 19:28
@BradLugo BradLugo merged commit 3c59c45 into master Aug 27, 2025
31 of 38 checks passed
@BradLugo BradLugo deleted the blugo/fix-s390x-psql-build branch August 27, 2025 19:49
@BradLugo BradLugo mentioned this pull request Aug 28, 2025
Merged
4 tasks
BradLugo added a commit that referenced this pull request Aug 28, 2025
@BradLugo
fix(ci): add specific psql version to fix s390x (#2092)
724cdf7
@BradLugo BradLugo mentioned this pull request Aug 28, 2025
Merged
dcaravel pushed a commit that referenced this pull request Sep 9, 2025
@BradLugo @dcaravel
fix(ci): add specific psql version to fix s390x (#2092)
787d1fa
@dcaravel dcaravel mentioned this pull request Sep 9, 2025
Merged
dcaravel pushed a commit that referenced this pull request Sep 10, 2025
@BradLugo @dcaravel
fix(ci): add specific psql version to fix s390x (#2092)
4049598
@dcaravel dcaravel mentioned this pull request Sep 10, 2025
Merged
@BradLugo BradLugo mentioned this pull request Feb 23, 2026
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daynewlee daynewlee daynewlee left review comments

@dcaravel dcaravel dcaravel approved these changes

@jvdm jvdm Awaiting requested review from jvdm

@RTann RTann Awaiting requested review from RTann

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BradLugo @daynewlee @dcaravel