-
Notifications
You must be signed in to change notification settings - Fork 13
ROX-26604: Backport lineage fix to ACS 4.6.x (Scanner 2.35.x) #1766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/retest |
let me cherry-pick some changes to help CI pass |
@dcaravel can you rebase? |
c41b822
to
1cee815
Compare
Done - let's see how it goes... |
@dcaravel: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I am afraid, this commit broke the RHCOS node scanning. Not sure which particular cherry-picked PR did that, but version 2.35.1 works fine, whereas 2.35.2 is broken, so the bug must be somewhere here. |
Perhaps not 😉 - looks like the RHCOS issue is external data/OVAL related. |
Indeed, the deeper investigation has been continued on Slack and there is no clear indication that this PR was faulty 👍 |
Adds the lineage fix for RHEL images to the Scanner 2.35 branch (targeting ACS 4.6.x).
Backports the lineage fix:
And other 'CI' fixes: