Take runtime.GOARCH into account for list manifests #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images are ready for the commit at 454c477. To use the images, use the tag |
RTann
reviewed
Aug 16, 2023
pkg/scan/scan.go
Outdated
| if foundAMD { | ||
| return handleManifest(reg, amdManifest.MediaType, remote, amdManifest.Digest.String()) | ||
| } | ||
| return "", nil, errors.Errorf("no manifest in list matched linux and amd64 or %s architectures: %q", runtime.GOARCH, ref) |
There was a problem hiding this comment.
nit: can you add remote, too?
| if len(manifests) == 0 { | ||
| return "", nil, errors.Errorf("no valid manifests found for %s:%s", remote, ref) | ||
| } | ||
| if len(manifests) == 1 { |
There was a problem hiding this comment.
is this case needed? should be covered by the loop, right? plus, I think this allows non-linux platforms, too
There was a problem hiding this comment.
So this actually deviates from what central does today:
if len(manifestList.Manifests) == 1 {
return handleManifests(r, manifestList.Manifests[0].MediaType, remote, manifestList.Manifests[0].Digest.String())
}
```
connorgorman
force-pushed
the
cgorman-manifest-list
branch
from
92c2342 to
454c477
Compare
RTann
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.