fix: do not skip NVD vulns with just CVSSv3 #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images are ready for the commit at c35805a. To use the images, use the tag |
RTann
force-pushed
the
ross/nvd-dont-skip
branch
from
f76a96b to
cee9597
Compare
RTann
added
the
generate-dumps-on-pr
RTann
force-pushed
the
ross/nvd-dont-skip
branch
2 times, most recently
from
355a4ff to
ba648a9
Compare
RTann
force-pushed
the
ross/nvd-dont-skip
branch
from
ba648a9 to
a78c60c
Compare
RTann
commented
Aug 21, 2023
| @@ -13,168 +12,7 @@ type updater struct { | |||
| } | |||
|
|
|||
| // Vulnerabilities lists vulnerabilities which may not already exist in the feeds for other distros. | |||
| var Vulnerabilities = []database.Vulnerability{ | |||
There was a problem hiding this comment.
These entries are no longer required, as we can fetch their entries from NVD properly now
RTann
force-pushed
the
ross/nvd-dont-skip
branch
from
184ef97 to
e43c686
Compare
RTann
force-pushed
the
ross/nvd-dont-skip
branch
from
e43c686 to
c35805a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before updating the condition:
After:
We were ignoring a lot of vulnerabilities solely because they lacked CVSSv2 scores.
Note: this change caused some tests to update. This is expected, as we did not have all the vulnerability data as we should have had. Each update is related to this update. You can verify this, if you choose.