ROX-17114: Fix misattribution of Java versions when there are multiple matching lines #1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorgorman
changed the title
daynewlee
reviewed
Jul 24, 2023
|
Images are ready for the commit at 09d189b. To use the images, use the tag |
connorgorman
commented
Jul 24, 2023
RTann
reviewed
Jul 24, 2023
|
I will be taking over this PR at this point |
daynewlee
approved these changes
Jul 26, 2023
RTann
force-pushed
the
cgorman-java-parse-manifests
branch
from
cf923db to
13ace86
Compare
RTann
force-pushed
the
cgorman-java-parse-manifests
branch
2 times, most recently
from
e1d38ed to
55e656d
Compare
RTann
force-pushed
the
cgorman-java-parse-manifests
branch
from
55e656d to
09d189b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we don't stop early if we have matched all the possible key lines in the manifest.mf file. This file can contain many entries and this will cause us to attribute the data to a wrong version