chore: log requests upon retrieval #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images are ready for the commit at 1ccc31e. To use the images, use the tag |
RTann
force-pushed
the
ross/server-logging
branch
from
524c2ce to
679c526
Compare
RTann
force-pushed
the
ross/server-logging
branch
2 times, most recently
from
f371323 to
fbb7c9c
Compare
dcaravel
approved these changes
Aug 23, 2023
Comment on lines
+206
to
+210
| imageName := "unknown" | ||
| if req.GetImage() != "" { | ||
| imageName = req.GetImage() | ||
| } | ||
| logrus.Infof("Fetching vulnerabilities for %s", imageName) |
There was a problem hiding this comment.
Should we add to the backlog modifying the invocations from Central/Sensor to add the image name?
There was a problem hiding this comment.
api/grpc/logging_interceptor.go
Outdated
Comment on lines
18
to
26
| return func(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) { | ||
| peerInfo, exists := peer.FromContext(ctx) | ||
| if !exists { | ||
| return nil, status.Error(codes.InvalidArgument, "unable to parse peer information from request context") | ||
| } | ||
|
|
||
| logrus.WithFields(map[string]interface{}{ | ||
| "Method": info.FullMethod, | ||
| }).Infof("Received gRPC request from %v", peerInfo.Addr) |
There was a problem hiding this comment.
I'm not an expert on grpc-gateway - but looks like it supports adding X-Forwarded-For header to the context
Guessing should be able to extract the Metadata from the context, something like:
addrs := metadata.ValueFromIncomingContext(ctx, "X-Forwarded-For")
And then append the addrs to this log
There was a problem hiding this comment.
doesn't seem like we can rely on this:
{"Event":"Received gRPC request from unknown","HEADERS":{":authority":["localhost:8443"],"content-type":["application/grpc"],"user-agent":["grpc-go/1.57.0"]},"Level":"info","Location":"logging_interceptor.go:28","Method":"/scannerV1.ImageScanService/GetImageComponents","Time":"2023-08-23 22:25:36.923706"}
Going to revert back to the original but leave out the peer's address because it added no value
RTann
force-pushed
the
ross/server-logging
branch
from
fbb7c9c to
32262f0
Compare
1 task
RTann
force-pushed
the
ross/server-logging
branch
3 times, most recently
from
604ba3f to
1ccc31e
Compare
RTann
force-pushed
the
ross/server-logging
branch
from
1ccc31e to
526adf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up when looking into potential network issues between Central and Scanner. These logs will let us know about all incoming traffic to the HTTP and gRPC endpoints which are exposed by Scanner.