Skip to content

remove env isolator #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2022
Merged

remove env isolator #1035

merged 2 commits into from
Dec 17, 2022

Conversation

RTann
Copy link
Collaborator

@RTann RTann commented Dec 17, 2022

As of go1.18, this is no longer needed. It's time to part ways :(

jvdm
jvdm approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@jvdm jvdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RTann RTann merged commit 3432ef8 into master Dec 17, 2022
@RTann RTann deleted the ross/rm-envisolator branch December 17, 2022 00:50
@ghost
Copy link

ghost commented Dec 17, 2022

Images are ready for the commit at 98ff574.

To use the images, use the tag 2.27.x-12-g98ff5741db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdm jvdm jvdm approved these changes

@daynewlee daynewlee Awaiting requested review from daynewlee

@dhaus67 dhaus67 Awaiting requested review from dhaus67

@dcaravel dcaravel Awaiting requested review from dcaravel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RTann @jvdm