ROX-12967: Introduce local-nodescanner #1027
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Skipping CI for Draft Pull Request. |
|
Run against a UBI 8.7 image: |
|
Run against the unpacked RHCOS 4.11 ISO image with a live-copy rpm Packages DB: |
vikin91
reviewed
Dec 2, 2022
There was a problem hiding this comment.
This looks okay, but I see potential in documenting how this could be used without downloading the RHCOS iso.
I have also minor comments in the code.
I think we can merge this as a helper.
Maybe we could remove it from the Graphite stack and consider it separately (it does not depend on the code in #1026)?
| flag.Parse() | ||
|
|
||
| logrus.Infof("%v", path) | ||
| if path == "" { |
There was a problem hiding this comment.
We could validate this with path.Exists() (need to check the func, writing this from memory)
| flag.BoolVar(&uncertifiedRHEL, "uncertifiedRHEL", false, "Whether to treat this run as uncertified RHEL FS") | ||
| flag.Parse() | ||
|
|
||
| logrus.Infof("%v", path) |
There was a problem hiding this comment.
Maybe let's write here some reasonable text? Will scan %s maybe?
And I would go for %s and add nil check.
|
|
||
| components, err := nodes.Analyze("localnode", path, uncertifiedRHEL) | ||
| if err != nil { | ||
| logrus.Fatal(err) |
There was a problem hiding this comment.
Maybe some prefix here: Fatalf("Nodescan failed: %v", err)?
| // local-nodescanner is an application that allows you to run the node scan / inventory code locally on you machine. | ||
|
|
||
| // Required: | ||
| // Extracted filesystem from an RHCOS live .ISO (https://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/latest/) |
There was a problem hiding this comment.
This is optional, right? We could also use this on RHCOS or other mounted filesystem.
Comment on lines
+18
to
+21
| // How To: | ||
| // Download the ISO, extract with 7z x <iso-name>, then extract images/pxeboot/root.squashfs with 7z as well | ||
| // The root fs will be in ostree/deploy/rhcos/deploy/ | ||
| // Caveat: The image doesn't contain a populated rpm Package DB. You still need to get that from a running system, e.g. a node. |
There was a problem hiding this comment.
This looks also optional for me.
Maybe we should convert these comments into a small readme in the tools/local-nodescanner?
- Roll back RegEx change - Introduce IsRHCOSNamespace
- RHCOS has its RPM DB in a different path - RHCOS provides a CPE json in a different path
Maddosaurus
force-pushed
the
mm/rox-12967-fix-rhcos-detection
branch
from
8cd5f2a to
9fcc0a7
Compare
|
@Maddosaurus: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@Maddosaurus I still have this PR on my list - do we want to merge it or can it be dropped? |
|
Closing this PR to restart the process with a fresh main branch and slightly different methodology. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
local-nodescannerin thetoolsdirectory.Its goal is to run the code used for RHCOS node scanning, usually run by
Complianceon a Node, locally.As the local version expects a path to a filesystem as argument, it can either run in a live environment or on an unpacked filesystem on disk.
Testing:
path=/path=/path/to/extracted/dirIn case of the RHCOS FS, I copied a populated
/var/lib/rpm/Packagesfile from an OpenShift Node running RHCOS 4.11 and manually added it to the right folder in the unpacked FS dump.Results of both runs can be found in the comments below.