ROX-13435: fix RHELv2 updates #1012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes relating to the diff step in #928 caused RHELv2 updates to not work properly with older Scanner versions.
Older Scanner versions rely on
PackageInfos
to be populated. Genesis dumps no longer populate this field, and the diff converted each base dump'sPackageInfos
toPackages
. Instead, we should have converted the newPackages
to the oldPackageInfos
so older scanners would understand them properly.Local Testing Steps:
make build-updater
./bin/updater generate-dump --out-file test.zip
. This will generate the latest genesis dump with the latest vulnerabilities./test.sh
wheretest.sh
is defined belowPackageInfos
are populated the correct data. For example, you can unzip/tmp/diff-dumps/dump0/diff.zip
and look atrhelv2/vulns/RHEL9-rhel-9-including-unpatched.json
and verify "RHSA-2022:7288" has all the fields populated as expectedtest.sh:
test.json: