ROX-30836: implement hotreloading for monitored paths #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molter73
changed the title
Collaborator
Author
|
/retest |
1 similar comment
Collaborator
Author
|
/retest |
Molter73
force-pushed
the
mauro/ROX-30836/hotreload-paths
branch
from
080010c to
556f3c8
Compare
Collaborator
Author
|
After discussing with @Stringy offline, we decided to attempt to implement this without detaching the LSM hooks to try and minimize the downtime. This is implemented as follow up in #128 in order to keep the number of changes in this PR down. Keep this in mind when reviewing parts of this code that are modified on that PR (or even better, review that PR first and I'll merge it into this one). |
Stringy
approved these changes
Oct 23, 2025
Contributor
Stringy
left a comment
Stringy
left a comment
There was a problem hiding this comment.
One very minor nit, but otherwise LGTM
Molter73
force-pushed
the
mauro/ROX-30836/hotreload-output
branch
from
a75dddc to
642301c
Compare
Molter73
force-pushed
the
mauro/ROX-30836/hotreload-paths
branch
from
35111ae to
04c7e8a
Compare
Molter73
force-pushed
the
mauro/ROX-30836/hotreload-output
branch
from
642301c to
5b2adad
Compare
Molter73
force-pushed
the
mauro/ROX-30836/hotreload-paths
branch
from
04c7e8a to
a306241
Compare
This patch implements hotreloading for the monitored paths. In order to achieve this, the BPF worker will need to detach all LSM hooks before messing with the prefix path map in order to prevent any problems that may arise of events happening in undefined states. This is achieved by keeping a list of links for the programs and dropping them, then re-filling the list once the programs are re-attached. The path prefix map is cleared by keeping a copy of the list of paths that are being monitored, then the new list is added in and a copy of it is stored.
This patch makes it so detaching and reattaching programs is no longer needed for updating the list of monitored paths. This is achieved by first loading all the new paths into the BPF trie map and then removing the entries that are not part of the new configuration. An integration test was added to ensure adding new paths does not remove existing paths accidentally.
Molter73
force-pushed
the
mauro/ROX-30836/hotreload-paths
branch
from
a306241 to
e219451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch implements hotreloading for the monitored paths.
In order to achieve this, the BPF worker will need to detach all LSM hooks before messing with the prefix path map in order to prevent any problems that may arise of events happening in undefined states. This is achieved by keeping a list of links for the programs and dropping them, then re-filling the list once the programs are re-attached. The path prefix map is cleared by keeping a copy of the list of paths that are being monitored, then the new list is added in and a copy of it is stored.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Tested manually and added an integration test.