Open
Conversation
This should only have an effect on development, on CI the cache will not exist and the builds will always happen from scratch. A small cmake wrapper function has been created to abstract the common logic of configuring, compiling and installing on all modules. Output of `time make builder` from scratch and after making a change to one of the install scripts: ``` BUILD_BUILDER_IMAGE=true make builder 5.82s user 1.23s system 0% cpu 17:28.09 total BUILD_BUILDER_IMAGE=true make builder 5.35s user 0.91s system 4% cpu 2:06.03 total ```
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2541 +/- ##
=======================================
Coverage 28.83% 28.83%
=======================================
Files 96 96
Lines 5799 5799
Branches 2551 2551
=======================================
Hits 1672 1672
Misses 3408 3408
Partials 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This should only have an effect on development, on CI the cache will not exist and the builds will always happen from scratch.
A small cmake wrapper function has been created to abstract the common logic of configuring, compiling and installing on all modules.
In the past we have tried to use
ccachein a similar way, but that ended up being quite convoluted, this approach is a lot more straightforward IMO.Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Output of
time make builderfrom scratch and after making a change to one of the install scripts: