Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-18384: remove slim images from upstream #1963

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Nov 18, 2024

Description

Since we have deprecated full images from Collector, we now want to drop the -slim tag for all images, since all image flavours are now inherently slim.

This PR removes upstream slim image tagging from Collector.

There are sibling PRs, which I will list here as they become available, that remove slim image use in other areas (downstream builds and the main repo)

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

CI should be enough.

@Stringy Stringy requested a review from a team as a code owner November 18, 2024 09:55
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, we probably want to rename this job by dropping slim from it
image

Other than that, LGTM! Godspeed full images, you will not be missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants