-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RenderCoordinator errors recoverable #190
Conversation
This avoids unwrapping, and only adds the localized description when an error is associated with the case. I also added an unknown so that the catch can handle unexpected errors, if necessary.
Case statements with correlated errors instead of optionals
Any reason why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! You'll be a Swifty in no time hahah, thanks @ninjadev64 and @obvgab for helping out while I was asleep 😴
Just a few requested changes which are mostly about simplifying things that that were artefacts of previous attempts.
Hahah didn't see this until after I submitted my review, you beat me to it |
…ator in WithRenderCoordinator's content property not nullable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks much better, thanks! 🎉
I'll wait for the workflows to complete. |
Description
This pull request ensures that any errors that may surge in RenderCoordinator#init are propagated back to the UI and so that an error message is shown instead of crashing the entire client.
Fixes #175 (not sure if fully)
Type of change
Please delete options that are not relevant.
Checklist: