Skip to content

Conversation

@dmjb
Copy link
Member

@dmjb dmjb commented Feb 6, 2026

Allows the base image used in protocol builds to be overridden with thv run --runtime-image

@github-actions github-actions bot added the size/L Large PR: 600-999 lines changed label Feb 6, 2026
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 45.58824% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.97%. Comparing base (865272e) to head (b47a20b).

Files with missing lines Patch % Lines
pkg/config/interface.go 16.66% 10 Missing ⚠️
pkg/config/config.go 30.76% 9 Missing ⚠️
pkg/container/templates/templates.go 64.70% 5 Missing and 1 partial ⚠️
pkg/runner/protocol.go 58.33% 3 Missing and 2 partials ⚠️
pkg/runner/config_builder.go 0.00% 4 Missing ⚠️
pkg/runner/retriever/retriever.go 0.00% 2 Missing ⚠️
pkg/mcp/server/run_server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3662      +/-   ##
==========================================
- Coverage   65.99%   65.97%   -0.03%     
==========================================
  Files         415      416       +1     
  Lines       41192    41253      +61     
==========================================
+ Hits        27186    27218      +32     
- Misses      11911    11937      +26     
- Partials     2095     2098       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/L Large PR: 600-999 lines changed labels Feb 6, 2026
@dmjb dmjb force-pushed the runtime-tagged-images branch from a23380e to 5b9b16d Compare February 6, 2026 14:18
@github-actions github-actions bot added size/XL Extra large PR: 1000+ lines changed and removed size/L Large PR: 600-999 lines changed labels Feb 6, 2026
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large PR Detected

This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.

How to unblock this PR:

Add a section to your PR description with the following format:

## Large PR Justification

[Explain why this PR must be large, such as:]
- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformation

Alternative:

Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.

See our Contributing Guidelines for more details.


This review will be automatically dismissed once you add the justification section.

@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/XL Extra large PR: 1000+ lines changed labels Feb 6, 2026
@github-actions github-actions bot dismissed their stale review February 6, 2026 16:30

PR size has been reduced below the XL threshold. Thank you for splitting this up!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

✅ PR size has been reduced below the XL threshold. The size review has been dismissed and this PR can now proceed with normal review. Thank you for splitting this up!

@dmjb dmjb marked this pull request as ready for review February 6, 2026 16:33
@dmjb dmjb changed the title [WIP] Make base images for protocol builds configurable. Make base images for protocol builds configurable. Feb 6, 2026
@dmjb dmjb marked this pull request as draft February 6, 2026 16:34
@dmjb dmjb marked this pull request as ready for review February 6, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Large PR: 600-999 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants