Add OAuth handler infrastructure and discovery endpoints #3321
+457
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces the HTTP handler layer for the OAuth 2.0 authorization server. The Handler struct coordinates all OAuth/OIDC endpoints and provides route registration via chi router (consistent with ToolHive's API patterns). The discovery endpoints (/.well-known/openid-configuration and jwks.json) are fully implemented and OIDC Discovery 1.0 compliant, including the REQUIRED fields subject_types_supported and id_token_signing_alg_values_supported. The signing algorithms are dynamically extracted from the JWKS keys. OAuth endpoints (authorize, token, callback, register) are stubbed for future implementation. In the full authserver, the Handler is instantiated by server_impl.go with four dependencies: a fosite.OAuth2Provider (the OAuth protocol engine), AuthorizationServerConfig (issuer, token lifespans, signing keys), Storage (where OAuth state is persisted), and an upstream.Provider (for relaying tokens to/from the upstream IDP). The Server.Handler() method returns the chi router as http.Handler, which can be mounted into any HTTP server. This design keeps the handler layer focused on HTTP concerns while delegating OAuth logic to fosite and state management to the storage layer.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3321 +/- ##
==========================================
+ Coverage 64.63% 64.68% +0.05%
==========================================
Files 369 371 +2
Lines 35953 36021 +68
==========================================
+ Hits 23238 23300 +62
+ Misses 10889 10887 -2
- Partials 1826 1834 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tgrunnagle
approved these changes
Jan 16, 2026
| } | ||
| } | ||
|
|
||
| // OIDCDiscoveryHandler handles GET /.well-known/openid-configuration requests. |
Contributor
There was a problem hiding this comment.
Question: Do we also want to support /.well-known/oauth-authorization-server in case the client is not using OIDC discovery?
JAORMX
reviewed
Jan 16, 2026
|
|
||
| // OIDCDiscoveryDocument represents the OIDC discovery document structure. | ||
| // Implements OpenID Connect Discovery 1.0 specification. | ||
| type OIDCDiscoveryDocument struct { |
Collaborator
There was a problem hiding this comment.
Don't we have this in another package?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the HTTP handler layer for the OAuth 2.0 authorization server. The Handler struct coordinates all OAuth/OIDC endpoints and provides route registration via chi router (consistent with ToolHive's API patterns). The discovery endpoints (/.well-known/openid-configuration and jwks.json) are fully implemented and OIDC Discovery 1.0 compliant, including the REQUIRED fields subject_types_supported and id_token_signing_alg_values_supported. The signing algorithms are dynamically extracted from the JWKS keys. OAuth endpoints (authorize, token, callback, register) are stubbed for future implementation.
In the full authserver, the Handler is instantiated by server_impl.go with four dependencies: a fosite.OAuth2Provider (the OAuth protocol engine), AuthorizationServerConfig (issuer, token lifespans, signing keys), Storage (where OAuth state is persisted), and an upstream.Provider (for relaying tokens to/from the upstream IDP). The Server.Handler() method returns the chi router as http.Handler, which can be mounted into any HTTP server. This design keeps the handler layer focused on HTTP concerns while delegating OAuth logic to fosite and state management to the storage layer.