fix: correct transport type reporting in workload list endpoint #3313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanskarzz <sanskar.gur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3178
Description
This PR fixes a bug where the /api/v1beta/workloads (list) endpoint incorrectly reported the transport_type as streamable-http for workloads that were actually using stdio transport.
Changes
minimalRunConfigstruct inpkg/workloads/types/types.goto include the Transport field.WorkloadFromContainerInfoto:Load the actual transport type from the stored
RunConfig.Use state-of-truth transport type for both the domain model and URL generation.
Fall back to labels only if the run configuration is missing.