Skip to content

Conversation

@lujunsan
Copy link
Contributor

Remove yaml:",inline" tag from BaseServerMetadata embedding in
ImageMetadata struct. The yaml-only tag caused swaggo v2.0.0-rc5
to skip inlining the embedded fields in the OpenAPI schema, resulting
in missing fields like name, description, tier, status, etc.

Anonymous struct embedding without tags allows both proper JSON
marshaling and correct swagger schema generation.

Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
@lujunsan lujunsan requested a review from dmjb January 15, 2026 18:16
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.18%. Comparing base (1a1251b) to head (a9934c8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3311      +/-   ##
==========================================
- Coverage   64.20%   64.18%   -0.02%     
==========================================
  Files         365      365              
  Lines       35249    35249              
==========================================
- Hits        22630    22626       -4     
- Misses      10805    10812       +7     
+ Partials     1814     1811       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lujunsan lujunsan force-pushed the fix-swagger-embedded-struct-fields branch from b5a990e to a9934c8 Compare January 15, 2026 18:29
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Medium PR: 300-599 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants