Skip to content

Conversation

@amirejaz
Copy link
Contributor

Problem

The updateWorkload endpoint was using the HTTP request context (r.Context()) for async operations. When the handler returns, the request context gets cancelled, which can cause failures in async operations like lock acquisition.

Solution

Changed updateWorkload to use context.Background() instead of the request context, matching the pattern used by deleteWorkload, restartWorkload, and stopWorkload endpoints.

@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.20%. Comparing base (73d4f26) to head (2865162).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3307      +/-   ##
==========================================
+ Coverage   64.18%   64.20%   +0.01%     
==========================================
  Files         365      365              
  Lines       35244    35244              
==========================================
+ Hits        22623    22629       +6     
+ Misses      10810    10803       -7     
- Partials     1811     1812       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amirejaz amirejaz requested a review from dmjb January 15, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants