Skip to content

Conversation

@slyt3
Copy link
Contributor

@slyt3 slyt3 commented Jan 12, 2026

Description:

This PR aligns MCPRemoteProxy with MCPServer by standardizing the proxy port field naming.

Summary

  • Added proxyPort to MCPRemoteProxySpec
  • Deprecated the legacy port field
  • Preserved backward compatibility during the transition

Details

  • GetProxyPort() now resolves ports in the following order:
    1. proxyPort
    2. port
    3. default (8080)

  • Updated controller and deployment tests

  • Added test coverage to ensure proxyPort takes precedence over port

  • Verified existing resources using port continue to work

This improves API consistency across MCP resources while maintaining a smooth migration path for existing users.

Fixes #3102

@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Jan 12, 2026
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.17%. Comparing base (7a16b10) to head (3e91f4f).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3257      +/-   ##
==========================================
+ Coverage   63.65%   64.17%   +0.52%     
==========================================
  Files         361      365       +4     
  Lines       35449    35248     -201     
==========================================
+ Hits        22566    22622      +56     
+ Misses      11072    10817     -255     
+ Partials     1811     1809       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmjb
Copy link
Member

dmjb commented Jan 12, 2026

This looks like a worthwhile change to me. @ChrisJBurns @JAORMX any concerns?

@dmjb
Copy link
Member

dmjb commented Jan 12, 2026

@slyt3 You'll need to regenerate the CRDs. From the base of the project, run:

cd cmd/thv-operator/
task crdref-gen

@slyt3
Copy link
Contributor Author

slyt3 commented Jan 12, 2026

@slyt3 You'll need to regenerate the CRDs. From the base of the project, run:


cd cmd/thv-operator/

task crdref-gen

Done

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Jan 12, 2026
@dmjb
Copy link
Member

dmjb commented Jan 13, 2026

@slyt3 Looks good, but you'll also need to bump the helm chart under ./deploy/charts/operator-crds/Chart.yaml

After doing that, you may need to run task docs to update helm chart documentation.

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Jan 13, 2026
@ChrisJBurns
Copy link
Collaborator

@dmjb I remember being in favour of this but I think @JAORMX had some comments on it in a previous PR.

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Jan 13, 2026
@slyt3
Copy link
Contributor Author

slyt3 commented Jan 13, 2026

@slyt3 Looks good, but you'll also need to bump the helm chart under ./deploy/charts/operator-crds/Chart.yaml

After doing that, you may need to run task docs to update helm chart documentation.

done :)

- Bump toolhive-operator chart to 0.5.23
- Remove hardcoded runAsUser: 1000 from operator values for better compatibility
- Replace cosign-installer with manual go install (v3.0.2) to fix version mismatch
- Optimize GitHub Actions cache configuration for Helm chart workflows
- Refresh Helm documentation (README.md) to reflect chart updates
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Jan 13, 2026
- Simplify pre-commit cache key in reusable workflows
- Add restore-keys to pre-commit cache to improve reliability
- Refresh Helm READMEs to reflect latest values
@github-actions github-actions bot removed the size/S Small PR: 100-299 lines changed label Jan 13, 2026
@github-actions github-actions bot added the size/S Small PR: 100-299 lines changed label Jan 13, 2026
- Update .pre-commit-config.yaml to use helm-docs v1.14.2
- Regenerate READMEs using the correct project templates to fix CI linting errors
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Jan 13, 2026
@slyt3
Copy link
Contributor Author

slyt3 commented Jan 13, 2026

Uh, I had multiple Helm validation failures and CI compatibility issues,

Its really IMPORTANT, because this is significant stabilization changes. Its started with minor update, but it evolved to kinda huge.

its important because Pipeline unblocked after I upgraded cosign and CI caching to fix persistent release and CI failures. also removed hardcodede UIDs from helm charts. soo it will allow project to run on restrcited platforms like OpenShift.

Copy link
Member

@dmjb dmjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slyt3 It looks like you included some changes to the github actions, and I see your comment about running into various problems. We haven't noticed any issues with the CI in our repo, were you trying to run them in your repo?

- name: Setup helm-docs
run: go install github.com/norwoodj/helm-docs/cmd/helm-docs@latest

- name: Cache Helm dependencies
Copy link
Member

@dmjb dmjb Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see an explanation of why this is necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this cache is just pre-commit tool env. ~/.cache/pre-commit it just avoids redownloading and reinstalling tools like heml-docs and other depend. on every CI run. Withouit it, each workflow execution would spend extra time setting up the same tools from 0 and it just slow down the pipeline

Replace manual go install approach with proper cosign-installer action usage.
This addresses PR feedback to use the action's built-in version parameter
instead of bypassing it with manual installation.
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Jan 14, 2026
@slyt3
Copy link
Contributor Author

slyt3 commented Jan 14, 2026

The CRD changes were already bumped to 0.0.95 earlier in this PR. have to bump to 0.0.96 to satisfy the linter.

@slyt3 slyt3 requested a review from dmjb January 14, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Small PR: 100-299 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCPRemoteProxy should use proxyPort for consistency with MCPServer

3 participants