-
Notifications
You must be signed in to change notification settings - Fork 171
Standardize proxy port field in MCPRemoteProxy #3257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update registry from toolhive-registry release v2025.12.16
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3257 +/- ##
==========================================
+ Coverage 63.65% 64.17% +0.52%
==========================================
Files 361 365 +4
Lines 35449 35248 -201
==========================================
+ Hits 22566 22622 +56
+ Misses 11072 10817 -255
+ Partials 1811 1809 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This looks like a worthwhile change to me. @ChrisJBurns @JAORMX any concerns? |
|
@slyt3 You'll need to regenerate the CRDs. From the base of the project, run: |
Done |
|
@slyt3 Looks good, but you'll also need to bump the helm chart under After doing that, you may need to run |
|
@dmjb I remember being in favour of this but I think @JAORMX had some comments on it in a previous PR. |
done :) |
- Bump toolhive-operator chart to 0.5.23 - Remove hardcoded runAsUser: 1000 from operator values for better compatibility - Replace cosign-installer with manual go install (v3.0.2) to fix version mismatch - Optimize GitHub Actions cache configuration for Helm chart workflows - Refresh Helm documentation (README.md) to reflect chart updates
- Simplify pre-commit cache key in reusable workflows - Add restore-keys to pre-commit cache to improve reliability - Refresh Helm READMEs to reflect latest values
- Update .pre-commit-config.yaml to use helm-docs v1.14.2 - Regenerate READMEs using the correct project templates to fix CI linting errors
|
Uh, I had multiple Helm validation failures and CI compatibility issues, Its really IMPORTANT, because this is significant stabilization changes. Its started with minor update, but it evolved to kinda huge. its important because Pipeline unblocked after I upgraded cosign and CI caching to fix persistent release and CI failures. also removed hardcodede UIDs from helm charts. soo it will allow project to run on restrcited platforms like OpenShift. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slyt3 It looks like you included some changes to the github actions, and I see your comment about running into various problems. We haven't noticed any issues with the CI in our repo, were you trying to run them in your repo?
| - name: Setup helm-docs | ||
| run: go install github.com/norwoodj/helm-docs/cmd/helm-docs@latest | ||
|
|
||
| - name: Cache Helm dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see an explanation of why this is necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this cache is just pre-commit tool env. ~/.cache/pre-commit it just avoids redownloading and reinstalling tools like heml-docs and other depend. on every CI run. Withouit it, each workflow execution would spend extra time setting up the same tools from 0 and it just slow down the pipeline
Replace manual go install approach with proper cosign-installer action usage. This addresses PR feedback to use the action's built-in version parameter instead of bypassing it with manual installation.
|
The CRD changes were already bumped to 0.0.95 earlier in this PR. have to bump to 0.0.96 to satisfy the linter. |
Description:
This PR aligns MCPRemoteProxy with MCPServer by standardizing the proxy port field naming.
Summary
Details
GetProxyPort() now resolves ports in the following order:
1. proxyPort
2. port
3. default (8080)
Updated controller and deployment tests
Added test coverage to ensure proxyPort takes precedence over port
Verified existing resources using port continue to work
This improves API consistency across MCP resources while maintaining a smooth migration path for existing users.
Fixes #3102