Use standard JSON Schema format for VMCP composite tool parameters #2651

JAORMX · 2025-11-18T23:22:33Z

Summary

Changes composite tool parameter definitions to use standard JSON Schema format per the MCP specification, instead of a non-standard simplified format.

Breaking Change

Composite tool parameter format has changed from:

parameters:
  param1:
    type: "string"
    default: "value"

To standard JSON Schema:

parameters:
  type: object
  properties:
    param1:
      type: string
      default: "value"
  required: ["param1"]

Changes

Update CompositeToolConfig.Parameters to map[string]any (full JSON Schema)
Remove parameter transformation logic from yaml_loader and workflow_converter
Add JSON Schema validation in yaml_loader (checks type: object)
Update Kubernetes CRDs to use runtime.RawExtension for parameters
Update webhook validation to handle runtime.RawExtension
Regenerate CRD manifests and deepcopy code
Bump operator-crds Helm chart from 0.0.59 to 0.0.60
Update all tests and documentation

Test plan

All existing tests pass
Linting passes (0 issues)
Updated tests to use new JSON Schema format
Validated error messages match new validation logic

🤖 Generated with Claude Code

codecov · 2025-11-18T23:28:46Z

Codecov Report

❌ Patch coverage is 63.41463% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.28%. Comparing base (315158c) to head (95d49b8).

Files with missing lines	Patch %	Lines
pkg/vmcp/config/yaml_loader.go	65.21%	5 Missing and 3 partials ⚠️
...lpha1/virtualmcpcompositetooldefinition_webhook.go	46.15%	3 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2651      +/-   ##
==========================================
+ Coverage   55.21%   55.28%   +0.07%     
==========================================
  Files         315      315              
  Lines       30123    30110      -13     
==========================================
+ Hits        16632    16647      +15     
+ Misses      12047    12011      -36     
- Partials     1444     1452       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jhrozek · 2025-11-19T11:22:10Z

deploy/charts/operator-crds/README.md

-```console
-helm uninstall <release_name>
-```
-


It's not expected this file go mangled is it?

jhrozek · 2025-11-19T11:22:49Z

docs/proposals/THV-2106-virtual-mcp-server.md

    description: "Deploy PR with user confirmation and notification"
    parameters:
-      pr_number: {type: "integer"}
+      type: object


hah, this is probably tripping CI..good on you to change the proposal retroactively. We might need to override CI this time

jhrozek · 2025-11-19T11:23:22Z

cmd/thv-operator/pkg/vmcpconfig/converter.go

+		if crdTool.Parameters != nil && len(crdTool.Parameters.Raw) > 0 {
+			var params map[string]any
+			if err := json.Unmarshal(crdTool.Parameters.Raw, &params); err == nil {
+				tool.Parameters = params


Is it expected the error is ignored?

related: we should probably have a unit test for this

jhrozek

Looking good! I added some nits. Only because I was reviewing the docs earlier this week do I know that we in fact have docs (docs/operator/advanced-workflow-patterns.md and docs/operator/virtualmcpcompositetooldefinition-guide.md) that @tgrunnagle wrote, thos should probably be updated as well

Fixes #2650 Changes composite tool parameter definitions to use standard JSON Schema format per the MCP specification, instead of a non-standard simplified format. **Breaking Change**: Composite tool parameter format has changed from: ```yaml parameters: param1: type: "string" default: "value" ``` To standard JSON Schema: ```yaml parameters: type: object properties: param1: type: string default: "value" required: ["param1"] ``` Changes: - Update CompositeToolConfig.Parameters to map[string]any (full JSON Schema) - Remove parameter transformation logic from yaml_loader and workflow_converter - Add JSON Schema validation in yaml_loader (checks type: object) - Update Kubernetes CRDs to use runtime.RawExtension for parameters - Update webhook validation to handle runtime.RawExtension - Regenerate CRD manifests and deepcopy code - Update all tests and documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

- Fix operator-crds README.md that was accidentally emptied - Add comprehensive unit tests for composite tool parameter conversion - Improve error handling documentation in converter.go - Bump toolhive-operator Helm chart version from 0.5.2 to 0.5.3 - Update all documentation to use standard JSON Schema format for parameters 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

tgrunnagle

Couple of questions but non-blocking

tgrunnagle · 2025-11-19T15:02:16Z

pkg/vmcp/config/config.go

+	//     },
+	//     "required": ["param2"]
+	//   }
+	Parameters map[string]any `json:"parameters,omitempty"`


Is it possible to have strong typing with something like

... Parameters map[string]ParameterEntry `json:"parameters,omitempty"` ... type ParameterEntry struct { Type string `json:type` Description string `json:description` Properties map[string]ParameterEntry `json:properties,omitempty` // optional, used with type == object

tgrunnagle · 2025-11-19T15:05:08Z

pkg/vmcp/config/yaml_loader.go

+	}
+
+	// Type should be "object" for parameter schemas
+	if typeStr != "object" {


My understanding is that we want to support non-object top level parameters? Maybe I'm confused https://stacklok.slack.com/archives/C09L9QF47EU/p1763562651723149?thread_ts=1763507520.825579&cid=C09L9QF47EU

JAORMX force-pushed the fix-vmcp-composite-tool-parameters-json-schema branch from 3b5b3da to b88bc23 Compare November 18, 2025 23:23

jhrozek reviewed Nov 19, 2025

View reviewed changes

JAORMX and others added 2 commits November 19, 2025 06:36

JAORMX force-pushed the fix-vmcp-composite-tool-parameters-json-schema branch from b88bc23 to 95d49b8 Compare November 19, 2025 12:57

JAORMX requested a review from jhrozek November 19, 2025 13:02

jhrozek approved these changes Nov 19, 2025

View reviewed changes

tgrunnagle approved these changes Nov 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use standard JSON Schema format for VMCP composite tool parameters #2651

Use standard JSON Schema format for VMCP composite tool parameters #2651

Uh oh!

JAORMX commented Nov 18, 2025

Uh oh!

codecov bot commented Nov 18, 2025 •

edited

Loading

Uh oh!

jhrozek Nov 19, 2025

Uh oh!

jhrozek Nov 19, 2025

Uh oh!

jhrozek Nov 19, 2025

Uh oh!

jhrozek Nov 19, 2025

Uh oh!

jhrozek left a comment

Uh oh!

tgrunnagle left a comment

Uh oh!

tgrunnagle Nov 19, 2025 •

edited

Loading

Uh oh!

tgrunnagle Nov 19, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Use standard JSON Schema format for VMCP composite tool parameters #2651

Are you sure you want to change the base?

Use standard JSON Schema format for VMCP composite tool parameters #2651

Uh oh!

Conversation

JAORMX commented Nov 18, 2025

Summary

Breaking Change

Changes

Test plan

Uh oh!

codecov bot commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jhrozek Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

jhrozek Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

jhrozek Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

jhrozek Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

jhrozek left a comment

Choose a reason for hiding this comment

Uh oh!

tgrunnagle left a comment

Choose a reason for hiding this comment

Uh oh!

tgrunnagle Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgrunnagle Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Nov 18, 2025 •

edited

Loading

tgrunnagle Nov 19, 2025 •

edited

Loading

tgrunnagle Nov 19, 2025 •

edited

Loading