-
Notifications
You must be signed in to change notification settings - Fork 145
refactor: registry package types #2615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2615 +/- ##
==========================================
+ Coverage 55.20% 55.23% +0.02%
==========================================
Files 315 315
Lines 30123 30123
==========================================
+ Hits 16630 16638 +8
+ Misses 12049 12036 -13
- Partials 1444 1449 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e8657cc to
32b6328
Compare
891cc51 to
32984bd
Compare
|
@peppescg @dmjb FYI, this broke some code in the toolhive-registry-server dependant repo, maybe we need some coordination before updating exported pkg names. Fixed in stacklok/toolhive-registry-server#139 |
@dmartinol sorry for that and thanks for the fix. You're right that we need to coordinate, our fault sorry. |
@dmartinol that's our fault, we were aware this was coming (and actually helped making it land). The underlying problem is that |
The Swagger/OpenAPI documentation generated by
swaggo/swagwas creating schema definitions with names derived from the Go package structure, specifically using types.* as the schema prefix (e.g., types.ImageMetadata, types.RemoteServerMetadata, types.EnvVar, types.Header, etc.).This naming convention was problematic for the
toolhive-studiocause typescript will usetypes.EnvVarrather thanRegistry.EnvVarFixed move up the type files