Improve composite tool watch integration tests #2604
+179
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
previously approved these changes
Nov 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2604 +/- ##
=======================================
Coverage 55.84% 55.84%
=======================================
Files 312 312
Lines 29541 29541
=======================================
+ Hits 16496 16498 +2
+ Misses 11603 11601 -2
Partials 1442 1442 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enhance integration tests for VirtualMCPCompositeToolDefinition watch functionality to verify reconciliation actually occurs. The original tests used Consistently to check ObservedGeneration stayed current, but this couldn't distinguish between "reconciliation occurred and completed" vs "no reconciliation was triggered". ResourceVersion changes when the controller updates status during reconciliation, providing definitive proof that the watch functionality works correctly.
jhrozek
force-pushed
the
feat/watch_vmcp_tool_composition
branch
from
00b695e to
7974464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance integration tests for VirtualMCPCompositeToolDefinition watch functionality to verify reconciliation actually occurs.
The original tests used Consistently to check ObservedGeneration stayed current, but this couldn't distinguish between "reconciliation occurred and completed" vs "no reconciliation was triggered". ResourceVersion changes when the controller updates status during reconciliation, providing definitive proof that the watch functionality works correctly.