Fix server port when network mode is host
#2353
Merged
+59
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
- Coverage 54.26% 53.90% -0.37%
==========================================
Files 242 250 +8
Lines 23446 23977 +531
==========================================
+ Hits 12724 12924 +200
- Misses 9514 9829 +315
- Partials 1208 1224 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blkt
force-pushed
the
hack/fix-mcp-port-host-network-linux
branch
from
4aac9f7 to
508b2b3
Compare
Docker networking works differently depending on whether it's running inside a VM or on the (linux) host itself, with VM-based installations like Docker Desktop not supporting `host` network. What happens is that the port is exposed on the VM rather than the actual host. Note that this is the case for linux running Docker Desktop. On the other hand, Docker Engine installations work just fine on linux, but we were still configuring the Proxy to try to connect to the wrong port. This is PR assumes that * all linux installations run docker engine * all non-linux installations run on VMs Fixes #2317
blkt
force-pushed
the
hack/fix-mcp-port-host-network-linux
branch
from
508b2b3 to
0624596
Compare
JAORMX
approved these changes
Oct 29, 2025
aponcedeleonch
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker networking works differently depending on whether it's running inside a VM or on the (linux) host itself, with VM-based installations like Docker Desktop not supporting
hostnetwork. What happens is that the port is exposed on the VM rather than the actual host. Note that this is the case for linux running Docker Desktop.On the other hand, Docker Engine installations work just fine on linux, but we were still configuring the Proxy to try to connect to the wrong port.
This is PR assumes that
Fixes #2317