Skip to content

Conversation

@ChrisJBurns
Copy link
Collaborator

There were still some pieces of flag code lying around the code base as well as some supporting functions that were unused.

Ref: #2195

Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.28%. Comparing base (2642816) to head (ef45ee2).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...md/thv-operator/controllers/mcpserver_runconfig.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2343      +/-   ##
==========================================
+ Coverage   54.22%   54.28%   +0.05%     
==========================================
  Files         241      241              
  Lines       23602    23446     -156     
==========================================
- Hits        12798    12727      -71     
+ Misses       9592     9505      -87     
- Partials     1212     1214       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisJBurns ChrisJBurns enabled auto-merge (squash) October 27, 2025 21:34
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these really do look unused, great work trimming the fat

@ChrisJBurns ChrisJBurns merged commit 615eb39 into main Oct 28, 2025
26 checks passed
@ChrisJBurns ChrisJBurns deleted the removes-unused-flags branch October 28, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants